Only supporting generated columns with valid string expressions#281
Merged
Only supporting generated columns with valid string expressions#281
Conversation
skejserjensen
approved these changes
Jan 31, 2025
chrthomsen
approved these changes
Feb 4, 2025
CGodiksen
force-pushed
the
dev/valid-generated-columns
branch
from
00de27f to
adc096d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #280 by changing the
original_exprfield onGeneratedColumnto beStringinstead ofOption<String>. This means that it is no longer possibly to create a generated column from which a string expression cannot be extracted.